-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kubernetes v1.31 #1840
Conversation
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@@ -202,7 +202,7 @@ func Add( | |||
nodePortRange: nodePortRange, | |||
overrideBootstrapKubeletAPIServer: overrideBootstrapKubeletAPIServer, | |||
} | |||
utilruntime.ErrorHandlers = append(utilruntime.ErrorHandlers, func(error) { | |||
utilruntime.ErrorHandlers = append(utilruntime.ErrorHandlers, func(context.Context, error, string, ...interface{}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context for this change kubernetes/kubernetes#121970
/approve |
LGTM label has been added. Git tree hash: e16887b0abc5c1a8508467f0a308842c7ebb5925
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
What type of PR is this?
/kind feature
Special notes for your reviewer:
I'll follow up with another PR to try to get tests working for providers that originally used the in-tree CCM.
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation:
/assign @xrstf